-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dnspython deprecation warning #5117
base: master
Are you sure you want to change the base?
Conversation
Where previously we used dns.resolver.query(), switch to d.r.resolve() Complete compatibility would require d.r.resolve(search=True) but this works without it so far. Perhaps see also rthalley/dnspython#581
This has dependencies and interrelated issues. IIRC, the primary issue surrounding this was that the replacement for the deprecated function wasn't available in a dnspython version which is compatible with Python 3.5. So, fixing this issue requires:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See previous comment.
Looks like dnsresolver class with the modifiable resolver class in here for configuration and use in the `!!/ip` call we used a while ago for DNS lookups of things (when we were debugging differing DNS records for domains) did not get the changes that #5117 was going to implement. So, implement.
I'm curious, but why would we need From the DNSPython configuration documents, this is what 'search' does:
We won't need Therefore, that function being added or not is irrelevant, I just tested the difference between |
Looks like dnsresolver class with the modifiable resolver class in here for configuration and use in the `!!/ip` call we used a while ago for DNS lookups of things (when we were debugging differing DNS records for domains) did not get the changes that Charcoal-SE#5117 was going to implement. So, implement.
Where previously we used dns.resolver.query(), switch to d.r.resolve()
Complete compatibility would require d.r.resolve(search=True) but this works without it so far.
Perhaps see also rthalley/dnspython#581