-
Notifications
You must be signed in to change notification settings - Fork 20
Who will maintain this repo? #26
Comments
Sorry for the off-topic comment: Could you please review/merge #24? Thanks :) |
I'll take a look when at computer:
|
Update -- ya, def. don't have permissions. I have suggested I am willing to accept transfer [ https://docs.github.com/en/repositories/creating-and-managing-repositories/transferring-a-repository ] to continue to maintain for the good of the community of users. |
Is there any point of contact at ChartBoost to initiate the transfer? |
@charliermarsh would it make sense to pull this under the astral umbrella? Seems like a core functionality for the linter. |
Yeah, we can maintain an official GitHub Action. |
We can transfer it under Astral if someone has permissions to do so. |
👍 yeah I'm happy to maintain if it's transferred |
Tbd if you need to fork, unclear that chartboost legal will be ok with transfer [ had requested ] Great to also get in gh action marketplace, while I was employed there I failed at getting needed approvals to get gh developer license signed which was a prerequisite Ideally transfer occurs to better serve/transition the community of users. That is why I hadn't forked myself... without transfer, the best place for this to fork/live is likely in Astral. |
I will give it a week or so. If we don't hear back, we'll just create a new repo in the Astral org. |
I had permission to merge the PR. I think there is a bit of risk in adding an extra dependency, but it seems to be working fine. I'd like to wait until the repo is transferred so we can generate the release. |
Hopefully I'm not getting too ahead of myself - but can Astral also press the necessary buttons to become a "verified" publisher in the actions marketplace? One of the security options for GitHub actions within paid accounts is to restrict 3rd party actions to only those published by verified publishers, and some organizations require this for various supply-chain-security reasons. They document the necessary steps here: https://docs.github.com/en/apps/github-marketplace/github-marketplace-overview/applying-for-publisher-verification-for-your-organization |
@ffernandez92 -- ideally this winds up transferred to https://github.com/astral-sh ... I think GY has permissions to do that [ I imagine you do not? ] but perhaps waiting on [ lack of? ] legal approval? There isn't anything company specific/proprietary in here. Transfer would be the cleanest way to save the company from maintenance, AND esp. be kindest to the community by way of redirect, etc... But 🤷 . |
Any updates from someone who works at ChartBoost? It'd be great to provide uninterrupted service for the users of this. |
Thanks all for your thoughtful consideration of ensuring a smooth transition for this action! Just adding appreciation and encouragement as part of a team that uses it for our open source web application. :) |
@charliermarsh Can you please help us on merging this #29 |
@nitishxp we cannot merge pull requests here — ChartBoost has not taken any action towards transferring the project. |
@zanieb can we shift that repo under astra, that defect is literally blocking us for most of the things |
@nitishxp we do not have control over transfer of this repository, as discussed above — ChartBoost needs to take action for a seamless transition. We'll create our own action eventually, if it comes to that. |
The action is released under Apache 2, which is fairly permissive. Why not fork it under astral? |
If the repository is transferred instead, there won't be an interruption for existing users (usage will be redirected). |
Last I heard from employees [ I am no longer there ], this was going
through legal approval process to transfer. I can ask whether stuck, a
determination, or in-progress still. Also, I believe one guy who can
merge/maintain is on vacation currently, so tbd. Forking is permitted, not
the worst idea, but certainly much better if this can be transferred.
…On Sat, Aug 10, 2024, 9:03 AM Amin Sadeghi ***@***.***> wrote:
The action is released under Apache 2, which is fairly permissive. Why not
fork it under astral?
—
Reply to this email directly, view it on GitHub
<#26 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABGMTJDAUUZYMUGJ7AQTMN3ZQY2UTAVCNFSM6AAAAABGF4AQJGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBSGE4TIOJSGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
I think if we find time to prioritize it before the transfer completes, and there's no clear timeline, we'll just fork. But if the transfer completes before we get to it, that's obviously preferable. |
This repo has a github-actions bot actively closing open PRs because they're "stale" in the amount of time it's taking to transfer this. Can we just accept that there will be some loss of continuity and fork? When Chartboost finally gets back to this they can change the readme to direct people to the fork. |
Yeah we're just planning to fork it at this point. The bottleneck is finding time for us to prioritize taking over the action. |
@charliermarsh -- if you want to fork it, I can commit to starting to maintain. I am the original author but no longer have permissions/affiliation at/with ChartBoost. I am confident I can get them to write a README informing of the fork. Sounds like unlikley to get prioritization to get attention of lawyers. If that makes sense, later this week I should also be able to update docs via PRs to point to new location. Steps:
Do advise if you want me to help move this forward. |
Also happy to help. |
Creating a fork is the best course of action for this project. Please submit a README update PR when you have the new location created. |
@charliermarsh sorry for my impatience, I know everyone here is donating their time, but it feels like we have willpower to make this change and are getting mired down in process. It sounds like @brucearctor is willing and able to manage these changes for astral, so we should be able to achieve this with 3 actions in the github UI that should take no more than a few minutes:
|
I'll try to get to it today. |
I've forked the action here: https://github.com/astral-sh/ruff-action. I'd like to make some substantial changes to it but I don't want that to block the fork. |
Thanks for getting this done @charliermarsh ! I'll take some time later today to try to get some of the issues and auto-closed PRs that are here posted over there so we can at least discuss. |
@charliermarsh -- I never saw any message after you forked it about my offer. Is it safe to assume there is not a need/want for me to maintain the fork in astral-sh org? [ from the original author who lost permissions to this repo in April ] |
As per discussed, https://github.com/astral-sh/ruff-action is the new home of this project. Thanks for all the helps. This repository will be archived(read-only) very soon. For anyone referencing this repo in your Action jobs, please update them to use |
Now that I am no longer with ChartBoost, who will be maintaining this repo?
Perhaps we should give some permissions and/or redirect for the sake of the many users reliant on this?
ex, more than 1.2K public usages of 'chartboost/ruff-action' --> https://github.com/search?q=chartboost%2Fruff-action&type=code
https://github.blog/2013-05-16-repository-redirects-are-here/
The text was updated successfully, but these errors were encountered: