Skip to content
This repository has been archived by the owner on Oct 9, 2024. It is now read-only.

Who will maintain this repo? #26

Closed
brucearctor opened this issue Apr 14, 2024 · 36 comments · Fixed by #38
Closed

Who will maintain this repo? #26

brucearctor opened this issue Apr 14, 2024 · 36 comments · Fixed by #38

Comments

@brucearctor
Copy link
Contributor

Now that I am no longer with ChartBoost, who will be maintaining this repo?

Perhaps we should give some permissions and/or redirect for the sake of the many users reliant on this?

ex, more than 1.2K public usages of 'chartboost/ruff-action' --> https://github.com/search?q=chartboost%2Fruff-action&type=code

https://github.blog/2013-05-16-repository-redirects-are-here/

@brucearctor
Copy link
Contributor Author

@CB-GuangyaoXie ?

@ma-sadeghi
Copy link
Contributor

Sorry for the off-topic comment: Could you please review/merge #24? Thanks :)

@brucearctor
Copy link
Contributor Author

I'll take a look when at computer:

  • unclear whether I still have permissions.

  • need to look at your code, and consider risks if this introduces new dependencies

@brucearctor
Copy link
Contributor Author

Update -- ya, def. don't have permissions.

I have suggested I am willing to accept transfer [ https://docs.github.com/en/repositories/creating-and-managing-repositories/transferring-a-repository ] to continue to maintain for the good of the community of users.

@ma-sadeghi
Copy link
Contributor

Is there any point of contact at ChartBoost to initiate the transfer?

@augustelalande
Copy link

@charliermarsh would it make sense to pull this under the astral umbrella? Seems like a core functionality for the linter.

@charliermarsh
Copy link

Yeah, we can maintain an official GitHub Action.

@charliermarsh
Copy link

We can transfer it under Astral if someone has permissions to do so.

@augustelalande
Copy link

@daniel-barros ?

@zanieb
Copy link

zanieb commented May 20, 2024

👍 yeah I'm happy to maintain if it's transferred

@brucearctor
Copy link
Contributor Author

Tbd if you need to fork, unclear that chartboost legal will be ok with transfer [ had requested ]

Great to also get in gh action marketplace, while I was employed there I failed at getting needed approvals to get gh developer license signed which was a prerequisite

Ideally transfer occurs to better serve/transition the community of users. That is why I hadn't forked myself... without transfer, the best place for this to fork/live is likely in Astral.

@charliermarsh
Copy link

I will give it a week or so. If we don't hear back, we'll just create a new repo in the Astral org.

@ffernandez92
Copy link
Collaborator

ffernandez92 commented May 30, 2024

I had permission to merge the PR. I think there is a bit of risk in adding an extra dependency, but it seems to be working fine. I'd like to wait until the repo is transferred so we can generate the release.
Let me know if I can help with anything

@vitaliyf
Copy link

Hopefully I'm not getting too ahead of myself - but can Astral also press the necessary buttons to become a "verified" publisher in the actions marketplace? One of the security options for GitHub actions within paid accounts is to restrict 3rd party actions to only those published by verified publishers, and some organizations require this for various supply-chain-security reasons.

They document the necessary steps here: https://docs.github.com/en/apps/github-marketplace/github-marketplace-overview/applying-for-publisher-verification-for-your-organization

@brucearctor
Copy link
Contributor Author

@ffernandez92 -- ideally this winds up transferred to https://github.com/astral-sh ... I think GY has permissions to do that [ I imagine you do not? ] but perhaps waiting on [ lack of? ] legal approval?

There isn't anything company specific/proprietary in here. Transfer would be the cleanest way to save the company from maintenance, AND esp. be kindest to the community by way of redirect, etc... But 🤷 .

@zanieb
Copy link

zanieb commented Jun 6, 2024

Any updates from someone who works at ChartBoost? It'd be great to provide uninterrupted service for the users of this.

@brittag
Copy link

brittag commented Jul 2, 2024

Thanks all for your thoughtful consideration of ensuring a smooth transition for this action! Just adding appreciation and encouragement as part of a team that uses it for our open source web application. :)

@nitishxp
Copy link

nitishxp commented Aug 7, 2024

@charliermarsh Can you please help us on merging this #29

@zanieb
Copy link

zanieb commented Aug 7, 2024

@nitishxp we cannot merge pull requests here — ChartBoost has not taken any action towards transferring the project.

@nitishxp
Copy link

@zanieb can we shift that repo under astra, that defect is literally blocking us for most of the things

@zanieb
Copy link

zanieb commented Aug 10, 2024

@nitishxp we do not have control over transfer of this repository, as discussed above — ChartBoost needs to take action for a seamless transition.

We'll create our own action eventually, if it comes to that.

@ma-sadeghi
Copy link
Contributor

The action is released under Apache 2, which is fairly permissive. Why not fork it under astral?

@zanieb
Copy link

zanieb commented Aug 10, 2024

If the repository is transferred instead, there won't be an interruption for existing users (usage will be redirected).

@brucearctor
Copy link
Contributor Author

brucearctor commented Aug 10, 2024 via email

@charliermarsh
Copy link

I think if we find time to prioritize it before the transfer completes, and there's no clear timeline, we'll just fork. But if the transfer completes before we get to it, that's obviously preferable.

@DavidJFelix
Copy link
Contributor

This repo has a github-actions bot actively closing open PRs because they're "stale" in the amount of time it's taking to transfer this. Can we just accept that there will be some loss of continuity and fork? When Chartboost finally gets back to this they can change the readme to direct people to the fork.

@charliermarsh
Copy link

Yeah we're just planning to fork it at this point. The bottleneck is finding time for us to prioritize taking over the action.

@brucearctor
Copy link
Contributor Author

brucearctor commented Sep 9, 2024

@charliermarsh -- if you want to fork it, I can commit to starting to maintain. I am the original author but no longer have permissions/affiliation at/with ChartBoost. I am confident I can get them to write a README informing of the fork. Sounds like unlikley to get prioritization to get attention of lawyers. If that makes sense, later this week I should also be able to update docs via PRs to point to new location.

Steps:

  • FORK
  • Grant Me Permissions
  • I'll work with ChartBoost to update the README to point to new location
  • I'll submit PR to update docs to point to new location
  • etc

Do advise if you want me to help move this forward.

@DavidJFelix
Copy link
Contributor

Also happy to help.

@CB-GuangyaoXie
Copy link
Contributor

Creating a fork is the best course of action for this project. Please submit a README update PR when you have the new location created.

@DavidJFelix
Copy link
Contributor

@charliermarsh sorry for my impatience, I know everyone here is donating their time, but it feels like we have willpower to make this change and are getting mired down in process.

It sounds like @brucearctor is willing and able to manage these changes for astral, so we should be able to achieve this with 3 actions in the github UI that should take no more than a few minutes:

@charliermarsh
Copy link

I'll try to get to it today.

@charliermarsh
Copy link

I've forked the action here: https://github.com/astral-sh/ruff-action. I'd like to make some substantial changes to it but I don't want that to block the fork.

@DavidJFelix
Copy link
Contributor

Thanks for getting this done @charliermarsh ! I'll take some time later today to try to get some of the issues and auto-closed PRs that are here posted over there so we can at least discuss.

@brucearctor
Copy link
Contributor Author

I've forked the action here: https://github.com/astral-sh/ruff-action. I'd like to make some substantial changes to it but I don't want that to block the fork.

@charliermarsh -- I never saw any message after you forked it about my offer. Is it safe to assume there is not a need/want for me to maintain the fork in astral-sh org? [ from the original author who lost permissions to this repo in April ]

@CB-GuangyaoXie
Copy link
Contributor

As per discussed, https://github.com/astral-sh/ruff-action is the new home of this project. Thanks for all the helps.

This repository will be archived(read-only) very soon. For anyone referencing this repo in your Action jobs, please update them to use astral-sh/ruff-action.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.