Skip to content

Commit

Permalink
Merge pull request #2377 from liuxuan30/Issue2356
Browse files Browse the repository at this point in the history
fix #2356 crash if floor(10.0 * intervalMagnitude) is 0.0
  • Loading branch information
liuxuan30 authored Jan 15, 2018
2 parents ba40ab4 + 5092512 commit 43ccf8e
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
3 changes: 2 additions & 1 deletion Source/Charts/Renderers/AxisRendererBase.swift
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,8 @@ open class AxisRendererBase: Renderer
if intervalSigDigit > 5
{
// Use one order of magnitude higher, to avoid intervals like 0.9 or 90
interval = floor(10.0 * Double(intervalMagnitude))
// if it's 0.0 after floor(), we use the old value
interval = floor(10.0 * intervalMagnitude) == 0.0 ? interval : floor(10.0 * intervalMagnitude)
}

var n = axis.centerAxisLabelsEnabled ? 1 : 0
Expand Down
6 changes: 3 additions & 3 deletions Source/Charts/Renderers/YAxisRendererRadarChart.swift
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,9 @@ open class YAxisRendererRadarChart: YAxisRenderer

if intervalSigDigit > 5
{
// Use one order of magnitude higher, to avoid intervals like 0.9 or
// 90
interval = floor(10 * intervalMagnitude)
// Use one order of magnitude higher, to avoid intervals like 0.9 or 90
// if it's 0.0 after floor(), we use the old value
interval = floor(10.0 * intervalMagnitude) == 0.0 ? interval : floor(10.0 * intervalMagnitude)
}

let centeringEnabled = axis.isCenterAxisLabelsEnabled
Expand Down

0 comments on commit 43ccf8e

Please sign in to comment.