Merge pull request #635 from danielgindi/fix-tests

Add missing images for bar chart tests
ChartsOrg · Dec 30, 2015 · a972c08 · a972c08
2 parents 3e9c260 + cc7c36e
commit a972c08
Show file tree

Hide file tree

Showing 21 changed files with 10 additions and 7 deletions.
diff --git a/Charts/Charts.xcodeproj/xcshareddata/xcschemes/Charts-TV.xcscheme b/Charts/Charts.xcodeproj/xcshareddata/xcschemes/Charts-TV.xcscheme
@@ -26,7 +26,8 @@
       buildConfiguration = "Debug"
       selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
       selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
-      shouldUseLaunchSchemeArgsEnv = "YES">
+      shouldUseLaunchSchemeArgsEnv = "YES"
+      codeCoverageEnabled = "YES">
       <Testables>
          <TestableReference
             skipped = "NO">

diff --git a/Charts/Charts.xcodeproj/xcshareddata/xcschemes/Charts-iOS.xcscheme b/Charts/Charts.xcodeproj/xcshareddata/xcschemes/Charts-iOS.xcscheme
@@ -26,7 +26,8 @@
       buildConfiguration = "Debug"
       selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
       selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
-      shouldUseLaunchSchemeArgsEnv = "YES">
+      shouldUseLaunchSchemeArgsEnv = "YES"
+      codeCoverageEnabled = "YES">
       <Testables>
          <TestableReference
             skipped = "NO">

diff --git a/Charts/ChartsTests/BarChartTests.swift b/Charts/ChartsTests/BarChartTests.swift
@@ -54,25 +54,26 @@ class BarChartTests: FBSnapshotTestCase
 
     func testHideLeftAxis()
     {
-        chart.leftAxis.drawAxisLineEnabled = false
+        chart.leftAxis.enabled = false
         FBSnapshotVerifyView(chart)
     }
 
     func testHideRightAxis()
     {
-        chart.rightAxis.drawAxisLineEnabled = false
+        chart.rightAxis.enabled = false
         FBSnapshotVerifyView(chart)
     }
 
-    func testHideLeftAxisGridlines()
+    func testHideHorizontalGridlines()
     {
         chart.leftAxis.drawGridLinesEnabled = false
+        chart.rightAxis.drawGridLinesEnabled = false
         FBSnapshotVerifyView(chart)
     }
 
-    func testHideRightAxisGridlines()
+    func testHideVerticalGridlines()
     {
-        chart.rightAxis.drawGridLinesEnabled = false
+        chart.xAxis.drawGridLinesEnabled = false
         FBSnapshotVerifyView(chart)
     }
 }
diff --git a/...artsTests/ReferenceImages_32/ChartsTests.BarChartTests/testDefaultValues@2x.png b/...artsTests/ReferenceImages_32/ChartsTests.BarChartTests/testDefaultValues@2x.png
diff --git a/...ReferenceImages_32/ChartsTests.BarChartTests/testHideHorizontalGridlines@2x.png b/...ReferenceImages_32/ChartsTests.BarChartTests/testHideHorizontalGridlines@2x.png
diff --git a/...hartsTests/ReferenceImages_32/ChartsTests.BarChartTests/testHideLeftAxis@2x.png b/...hartsTests/ReferenceImages_32/ChartsTests.BarChartTests/testHideLeftAxis@2x.png
diff --git a/...artsTests/ReferenceImages_32/ChartsTests.BarChartTests/testHideRightAxis@2x.png b/...artsTests/ReferenceImages_32/ChartsTests.BarChartTests/testHideRightAxis@2x.png
diff --git a/...s/ReferenceImages_32/ChartsTests.BarChartTests/testHideVerticalGridlines@2x.png b/...s/ReferenceImages_32/ChartsTests.BarChartTests/testHideVerticalGridlines@2x.png
diff --git a/...ChartsTests/ReferenceImages_32/ChartsTests.BarChartTests/testHidesValues@2x.png b/...ChartsTests/ReferenceImages_32/ChartsTests.BarChartTests/testHidesValues@2x.png
diff --git a/...artsTests/ReferenceImages_64/ChartsTests.BarChartTests/testDefaultValues@3x.png b/...artsTests/ReferenceImages_64/ChartsTests.BarChartTests/testDefaultValues@3x.png
diff --git a/...ReferenceImages_64/ChartsTests.BarChartTests/testHideHorizontalGridlines@2x.png b/...ReferenceImages_64/ChartsTests.BarChartTests/testHideHorizontalGridlines@2x.png
diff --git a/...ReferenceImages_64/ChartsTests.BarChartTests/testHideHorizontalGridlines@3x.png b/...ReferenceImages_64/ChartsTests.BarChartTests/testHideHorizontalGridlines@3x.png
diff --git a/...hartsTests/ReferenceImages_64/ChartsTests.BarChartTests/testHideLeftAxis@2x.png b/...hartsTests/ReferenceImages_64/ChartsTests.BarChartTests/testHideLeftAxis@2x.png
diff --git a/...hartsTests/ReferenceImages_64/ChartsTests.BarChartTests/testHideLeftAxis@3x.png b/...hartsTests/ReferenceImages_64/ChartsTests.BarChartTests/testHideLeftAxis@3x.png
diff --git a/...s/ReferenceImages_64/ChartsTests.BarChartTests/testHideLeftAxisGridlines@2x.png b/...s/ReferenceImages_64/ChartsTests.BarChartTests/testHideLeftAxisGridlines@2x.png
diff --git a/...artsTests/ReferenceImages_64/ChartsTests.BarChartTests/testHideRightAxis@2x.png b/...artsTests/ReferenceImages_64/ChartsTests.BarChartTests/testHideRightAxis@2x.png
diff --git a/...artsTests/ReferenceImages_64/ChartsTests.BarChartTests/testHideRightAxis@3x.png b/...artsTests/ReferenceImages_64/ChartsTests.BarChartTests/testHideRightAxis@3x.png
diff --git a/.../ReferenceImages_64/ChartsTests.BarChartTests/testHideRightAxisGridlines@2x.png b/.../ReferenceImages_64/ChartsTests.BarChartTests/testHideRightAxisGridlines@2x.png
diff --git a/...s/ReferenceImages_64/ChartsTests.BarChartTests/testHideVerticalGridlines@2x.png b/...s/ReferenceImages_64/ChartsTests.BarChartTests/testHideVerticalGridlines@2x.png
diff --git a/...s/ReferenceImages_64/ChartsTests.BarChartTests/testHideVerticalGridlines@3x.png b/...s/ReferenceImages_64/ChartsTests.BarChartTests/testHideVerticalGridlines@3x.png
diff --git a/...ChartsTests/ReferenceImages_64/ChartsTests.BarChartTests/testHidesValues@3x.png b/...ChartsTests/ReferenceImages_64/ChartsTests.BarChartTests/testHidesValues@3x.png