Skip to content

Commit

Permalink
Use Swift count instead of lengthOfBytes (Issue #120)
Browse files Browse the repository at this point in the history
  • Loading branch information
danielgindi committed Jun 2, 2015
1 parent 18a3c50 commit fd82163
Show file tree
Hide file tree
Showing 9 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion Charts/Classes/Charts/ChartViewBase.swift
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ public class ChartViewBase: UIView, ChartAnimatorDelegate

ChartUtils.drawText(context: context, text: noDataText, point: CGPoint(x: frame.width / 2.0, y: frame.height / 2.0), align: .Center, attributes: [NSFontAttributeName: infoFont, NSForegroundColorAttributeName: infoTextColor]);

if (noDataTextDescription?.lengthOfBytesUsingEncoding(NSUTF16StringEncoding) > 0)
if (noDataTextDescription != nil && count(noDataTextDescription!) > 0)
{
var textOffset = -infoFont.lineHeight / 2.0;

Expand Down
2 changes: 1 addition & 1 deletion Charts/Classes/Components/ChartXAxis.swift
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ public class ChartXAxis: ChartAxisBase
{
var text = values[i];

if (text != nil && longest.lengthOfBytesUsingEncoding(NSUTF16StringEncoding) < text!.lengthOfBytesUsingEncoding(NSUTF16StringEncoding))
if (text != nil && count(longest) < count(text!))
{
longest = text!;
}
Expand Down
2 changes: 1 addition & 1 deletion Charts/Classes/Components/ChartYAxis.swift
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ public class ChartYAxis: ChartAxisBase
{
var text = getFormattedLabel(i);

if (longest.lengthOfBytesUsingEncoding(NSUTF16StringEncoding) < text.lengthOfBytesUsingEncoding(NSUTF16StringEncoding))
if (count(longest) < count(text))
{
longest = text;
}
Expand Down
2 changes: 1 addition & 1 deletion Charts/Classes/Data/ChartData.swift
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ public class ChartData: NSObject

for (var i = 0; i < _xVals.count; i++)
{
sum += _xVals[i] == nil ? 0 : _xVals[i]!.lengthOfBytesUsingEncoding(NSUTF16StringEncoding);
sum += _xVals[i] == nil ? 0 : count(_xVals[i]!);
}
_xValAverageLength = Float(sum) / Float(_xVals.count);
Expand Down
2 changes: 1 addition & 1 deletion Charts/Classes/Renderers/ChartXAxisRenderer.swift
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ public class ChartXAxisRenderer: ChartAxisRendererBase
var label = l.label;

// if drawing the limit-value label is enabled
if (label.lengthOfBytesUsingEncoding(NSUTF16StringEncoding) > 0)
if (count(label) > 0)
{
var labelLineHeight = l.valueFont.lineHeight;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ public class ChartXAxisRendererHorizontalBarChart: ChartXAxisRendererBarChart
var label = l.label;

// if drawing the limit-value label is enabled
if (label.lengthOfBytesUsingEncoding(NSUTF16StringEncoding) > 0)
if (count(label) > 0)
{
var labelLineHeight = l.valueFont.lineHeight;

Expand Down
2 changes: 1 addition & 1 deletion Charts/Classes/Renderers/ChartYAxisRenderer.swift
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ public class ChartYAxisRenderer: ChartAxisRendererBase
var label = l.label;

// if drawing the limit-value label is enabled
if (label.lengthOfBytesUsingEncoding(NSUTF16StringEncoding) > 0)
if (count(label) > 0)
{
var labelLineHeight = l.valueFont.lineHeight;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ public class ChartYAxisRendererHorizontalBarChart: ChartYAxisRenderer
var label = l.label;

// if drawing the limit-value label is enabled
if (label.lengthOfBytesUsingEncoding(NSUTF16StringEncoding) > 0)
if (count(label) > 0)
{
var labelLineHeight = l.valueFont.lineHeight;

Expand Down
2 changes: 1 addition & 1 deletion Charts/Classes/Renderers/PieChartRenderer.swift
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ public class PieChartRenderer: ChartDataRendererBase
/// draws the description text in the center of the pie chart makes most sense when center-hole is enabled
private func drawCenterText(#context: CGContext)
{
if (drawCenterTextEnabled && centerText != nil && centerText.lengthOfBytesUsingEncoding(NSUTF16StringEncoding) > 0)
if (drawCenterTextEnabled && centerText != nil && count(centerText) > 0)
{
var center = _chart.centerCircleBox;
var innerRadius = drawHoleEnabled && holeTransparent ? _chart.radius * holeRadiusPercent : _chart.radius;
Expand Down

0 comments on commit fd82163

Please sign in to comment.