Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BubbleChartRenderer colors from dataset issue (3.0.1) #2047

Open
chbachmann opened this issue Jan 9, 2017 · 2 comments
Open

BubbleChartRenderer colors from dataset issue (3.0.1) #2047

chbachmann opened this issue Jan 9, 2017 · 2 comments

Comments

@chbachmann
Copy link

The setting of the bubble color via dataset does not work as expected.
It looks lkie a bug to me:

In BubbleChartRenderer.swift on line 122 the code is:
let color = dataSet.color(atIndex: Int(entry.x))
I think it should be:
let color = dataSet.color(atIndex: Int(entry.x)):
let color = dataSet.color(atIndex: Int(j))
chbachmann pushed a commit to chbachmann/Charts that referenced this issue Jan 10, 2017
@mpbachmann
ChartsOrg#2047 BubbleChartRenderer colors from dataset issue (3.0.1)
e71b3f1
@chbachmann chbachmann mentioned this issue Jan 10, 2017
Closed
@chbachmann
Copy link
Author

Will this fix be merged?

@liuxuan30
Copy link
Member

need @danielgindi to confirm and merge.

liuxuan30 added a commit that referenced this issue Jan 26, 2018
@liuxuan30
Merge pull request #3202 from jjatie/3.1/#2047
9789320 
BubbleChart uses correct colour for index now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@liuxuan30 @chbachmann