Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rerun Image tests and make sure it pass #5033

Closed
liuxuan30 opened this issue Mar 24, 2023 · 0 comments
Closed

Rerun Image tests and make sure it pass #5033

liuxuan30 opened this issue Mar 24, 2023 · 0 comments
Milestone
5.0.0

Comments

@liuxuan30
Copy link
Member

Before we release 5.0, let's run the image tests and make sure it pass, if failed, let's check the diff and update the images
@liuxuan30 liuxuan30 added this to the 5.0.0 milestone Mar 24, 2023
@liuxuan30 liuxuan30 mentioned this issue Mar 24, 2023
Merged
pmairoldi added a commit that referenced this issue Jun 8, 2023
@pmairoldi
fix #5033: always run snapshot tests in light mode
51468ce
full-of-fire pushed a commit to full-of-fire/Charts that referenced this issue Jun 26, 2023
Merge branch 'master' of https://github.com/danielgindi/Charts
8e0893b 
* 'master' of https://github.com/danielgindi/Charts:
  update readme
  fix podspec
  update ci
  update readme versions
  fix build issue
  remove swift-algorithms package in favor of manully importing needed functions
  fix ChartsOrg#5033: always run snapshot tests in light mode
  update tvos
  undo framework bump
  bump min version to 13 for ios project
  Bump actions/checkout to v3
  Fix Xcode 14.3 import warnings
  add discardable results to operations that do not require result
  update readme to change name
  update workflow to run on release branches
  Change library name from Charts to DGCharts
  Unnecessary space Removal and Semicolons are removed
  Update README.md
  Turn on the BUILD_LIBRARY_FOR_DISTRIBUTION flag
  fixed no used warning

# Conflicts:
#	.github/workflows/swift.yml
#	Charts.xcodeproj/project.pbxproj
#	Charts.xcworkspace/xcshareddata/swiftpm/Package.resolved
#	DGCharts.podspec
#	README.md
ssup1 pushed a commit to ssup1/Charts that referenced this issue Jul 19, 2023
@pmairoldi @ssup1
fix ChartsOrg#5033: always run snapshot tests in light mode
89c5346
drewster99 pushed a commit to drewster99/Charts that referenced this issue Nov 8, 2023
@drewsterb
Merge branch 'gindi-master'
cd65641 
* gindi-master: (55 commits)
  [Feature] added ability to rotate ChartLimitLine label (ChartsOrg#5085)
  update readme
  fix podspec
  update ci
  update readme versions
  fix build issue
  remove swift-algorithms package in favor of manully importing needed functions
  fix ChartsOrg#5033: always run snapshot tests in light mode
  update tvos
  undo framework bump
  bump min version to 13 for ios project
  Bump actions/checkout to v3
  Fix Xcode 14.3 import warnings
  add discardable results to operations that do not require result
  update readme to change name
  update workflow to run on release branches
  Change library name from Charts to DGCharts
  Unnecessary space Removal and Semicolons are removed
  Update README.md
  Turn on the BUILD_LIBRARY_FOR_DISTRIBUTION flag
  ...
apollonian pushed a commit to foldmoney/Charts that referenced this issue Mar 11, 2024
@pmairoldi @apollonian
fix ChartsOrg#5033: always run snapshot tests in light mode
bcbacad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
2 participants
@pmairoldi @liuxuan30