Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add long press for toggle highlight #1142

Closed
wants to merge 8 commits into from

Conversation

juvham
Copy link

@juvham juvham commented Jun 15, 2016

for #1141

@liuxuan30
Copy link
Member

please squash your commits into one, and make the commit messages contains only English and meaningful.

Also, I see classes like 'TimeLineData', is this necessary or irrelevant? If the newly added classes are essential, please make an small introduction for what are they.

@liuxuan30
Copy link
Member

liuxuan30 commented Aug 5, 2016

When further looking into the code, I wonder if you just put your project into this PR? If this is all about long press gestures, why there are so many new data classes and protocol like XMinMaxProvider and new chart like KlineChartView?

I'm closing this PR and please separate long press gestures changes only into a new PR. Thanks.

@liuxuan30 liuxuan30 closed this Aug 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants