Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix position of value label in bar chart in case of on of the value is 0 #1195

Closed
wants to merge 2 commits into from
Closed

Fix position of value label in bar chart in case of on of the value is 0 #1195

wants to merge 2 commits into from

Conversation

skywinder
Copy link
Contributor

@skywinder skywinder commented Jun 29, 2016 •
edited
Loading

This will fix #1191 🎉

screen shot 2016-06-29 at 19 03 43

@skywinder
Copy link
Contributor Author

@petester42 please All tests are passed. Travis get error not related to PR:

The command "cd Charts && carthage bootstrap" failed and exited with 1 during .

@liuxuan30
Copy link
Member

would you please rebase with master (and squash if needed), I just fixed travis last week I think

@skywinder
Copy link
Contributor Author

skywinder commented Jul 4, 2016 •
edited
Loading

@msanders I just merged latest changes from master.
rebase is destructing command, so I prefer to not do it without special need.

@skywinder skywinder mentioned this pull request Aug 11, 2016
Closed
@danielgindi
Copy link
Collaborator

This actually introduces new bugs. Fix coming soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Double BarChart second value text mispaced
3 participants
@skywinder @liuxuan30 @danielgindi