Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve comment to warn users how to use setVisibleRange APIs #1245

Merged
merged 1 commit into from
Aug 5, 2016

Conversation

liuxuan30
Copy link
Member

Seeing some users don't know how to use setVisibleRange APIs (can only be called after we have data, otherwise no effect). For now, add the API description for this

@dxclancy
Copy link

Hi! This is a good idea but i find your change confusing. You description of your change in the parenthesis makes more sense to me. I would say something more like that. "Chart must have data or these have no effect".

@liuxuan30
Copy link
Member Author

@dxclancy thanks a lot, not a native speaker, so.. thanks

@liuxuan30 liuxuan30 merged commit f48fbfc into ChartsOrg:master Aug 5, 2016
@liuxuan30 liuxuan30 deleted the ImproveComment branch August 15, 2016 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants