Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cocoapods setup being broken #1509

Merged
merged 1 commit into from
Sep 21, 2016
Merged

Fix Cocoapods setup being broken #1509

merged 1 commit into from
Sep 21, 2016

Conversation

pmairoldi
Copy link
Collaborator

While working of the v2.3.0 release I noticed that there were problems with our podspec because we used a prepare_command. This is not really necessary and the same can be achieved with a compiler flag in the xcode project.

Changes:

  • Updates to cocoapods 1.1.0.rc.2 which supports xcode 8
  • Sets the swift version to 3.0 in ".swift-version" so cocoapods can use the right version
  • Uses a "NEEDS_CHARTS" compiler flag instead of a prepare_command (xcode project will have the flag set so that it uses import Charts while cocoapods will not so it will be ignored)
  • Bumps the version of the podspec to 3.0.0

If you have problems linting or pushing the pod to trunk you need to set an environment variable in order to get around some problem's with Realm's podspec due to cocoapod issues. To fix this run export FORK_XCODE_WRITING=true and everything should work.

pmairoldi referenced this pull request Sep 21, 2016
remove the prepare command since its not needed. To lint pod you need to set (export FORK_XCODE_WRITING=true) to get around the prepare_command issue with realm. Update cocoapods and include a swift-version file for safety
@danielgindi
Copy link
Collaborator

For me - you're the cocoapods-wiz, I know nothing about it except that it messes with my project settings too much ;-)
So if you're waiting for me to review, go ahead and merge...

@pmairoldi
Copy link
Collaborator Author

It was more to inform everyone about what was going on.

@pmairoldi pmairoldi merged commit 4efcc71 into master Sep 21, 2016
@pmairoldi pmairoldi deleted the fix-cocoapods branch September 25, 2016 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants