Issues #182, #122

[dorsoft]

#182 ChartData.removeEntryByXIndex removes the wrong entry
#122 Candle chart - make the shadow same color as an increasing/decreasing candle color

[danielgindi]

Hey man, thanks!
But:

1. You should separate those into two PRs (Just create two branches based on the latest commit, and cherry-pick the commits into them)
2. Please make sure code styling matches (That means { and } are on new lines, no ; in line endings in Swift)
3. For shadow colors, we are working on a different solution, possibly more flexible, so it's still pending :-)

[liuxuan30]

Hi @danielgindi, I am also new to submit different PRs.. Any wiki for this? what you mean by cherry-pick the commits into them?
What I have is only a master branch in my fork, and whenever I push to my origin master, github automatically put it into the same PR, though it is for different bug...

[danielgindi]

Well as I said, commit to different branches.
You can make a PR for each branch of yours.
https://help.github.com/articles/using-pull-requests/

[liuxuan30]

Thanks. I will follow this rule next time. For my previous PR #168, sorry I have merged several fixes together. most of them are related to the same issue.

[danielgindi]

Still, you need to just create branches, from the master commit before your
changes.
Then take your new commits and move to those branches

On Thu, Jul 2, 2015 at 8:29 AM, Xuan notifications@github.com wrote:

Thanks. I will follow this rule next time. For my previous PR #168
#168, sorry I have merged
several fixes together. most of them are related to the same issue.

—
Reply to this email directly or view it on GitHub
#183 (comment)
.

[liuxuan30]

Maybe we could talk about it in PR #168? This PR is old, and I have been keeping it synced with the latest code. So it can be automatically merged.