Allow PieChartView to hide labels for tiny slices - Swift 3 #2062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgod
reviewed
May 3, 2017
|
|
||
| if j < data.entryCount && pe?.label != nil | ||
| { | ||
| if chart.limitXLableSizeInSlice == true && size.width > ((labelRadius * sliceAngle * ChartUtils.Math.FDEG2RAD) + 10) { |
There was a problem hiding this comment.
This appears to have the bug described in the conversation for #944.
|
May I know what's the status of this merge conflict? |
|
@jjatie seems we can take it a higher priority? I just saw two new issues about this |
This was referenced Jan 10, 2018
|
@liuxuan30 agreed. I think the default behaviour should be to hide smaller labels too. If @hugobisson of this PR doesn't update it in the next few days, I will add it. Should this be targeted to 3.x or 4.0.0? I'm thinking 4.0.0. |
|
I'm ok either 3.x or 4.0. just make it easier to merge and fix conflicts. |
|
@hugobisson Can you fix this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refer to pull request #944 - Allow PieChartView to hide labels for tiny slices but in swift 3