Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Xcode 8.3 beta build issue #2116

Merged
merged 1 commit into from
Feb 2, 2017
Merged

Conversation

davidarve
Copy link

This fixes the following build error in Xcode 8.3 beta

/.../Charts/Source/Charts/Data/Implementations/Standard/ChartDataEntryBase.swift:61:40: Binary operator '!==' cannot be applied to operands of type 'AnyObject?!' and 'AnyObject?'

@pmairoldi
Copy link
Collaborator

pmairoldi commented Jan 25, 2017

I created a new Xcode 8.3 branch. If you could target your changes to that branch it would be great!

@davidarve davidarve changed the base branch from master to xcode-8.3 January 25, 2017 13:39
@davidarve
Copy link
Author

The failed build doesn't seem to have anything to do with the patch, could someone take a look at it?

@pmairoldi
Copy link
Collaborator

It actually is related. The fix you are proposing doesn't work in Xcode 8.2 that is why it is failing.

@davidarve
Copy link
Author

davidarve commented Jan 26, 2017

Hmm. That sucks. Does anyone have another solution? Otherwise I may have time to look at it closer later today.

This fixes the following build error in Xcode 8.3 beta
>/.../Charts/Source/Charts/Data/Implementations/Standard/ChartDataEntryBase.swift:61:40: Binary operator '!==' cannot be applied to operands of type 'AnyObject?!' and 'AnyObject?'
@codecov-io
Copy link

Current coverage is 18.54% (diff: 0.00%)

Merging #2116 into xcode-8.3 will increase coverage by 0.14%

@@           xcode-8.3      #2116   diff @@
===========================================
  Files            124        124          
  Lines          14305      14194   -111   
  Methods            0          0          
  Messages           0          0          
  Branches           0          0          
===========================================
  Hits            2632       2632          
+ Misses         11673      11562   -111   
  Partials           0          0          

Powered by Codecov. Last update 8532371...72c061d

@davidarve
Copy link
Author

I've updated the pull request. I don't understand and can't reproduce the current build failure with Xcode 8.2.

@pmairoldi
Copy link
Collaborator

The current error is fine. It happens from time to time.

@davidarve
Copy link
Author

Could someone trigger the build again to see if it can pass? @petester42? It would of course also be nice if we could run a Travis build using Xcode 8.3 beta to verify that the fix works.

@pmairoldi
Copy link
Collaborator

Xcode 8.3 beta is not available yet. We don't need to restart the build. It's fine 2 out of 3 platforms passed. Should be good.

@askielboe askielboe mentioned this pull request Feb 1, 2017
@pmairoldi pmairoldi merged commit b91cff0 into ChartsOrg:xcode-8.3 Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants