PieChart with Image Value #2328
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w beside the value label
|
what should I with these failing check ? could you please help me to merge these if possible ? |
|
Wait a minute, have you noticed #1793? Seems the same feature? What's the difference for this one? |
|
For the test failures, you have to rebase to master, seems you are still using old travis configuration. |
|
@liuxuan30 it is not same as #1793 , as you can find in my issue ticket , its just about pie chart. |
|
could you please help me find my travis configuration to update it ? how can I do that then ? |
|
You just merge master into your branch should be enough |
|
I couldn't fix this test fail idont know why , but I update another pull request new pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PieChartDataEntry can be initiated with an image, then image will show beside the value label. (Fixes #2318 )
Changes have made on PieChartDataEntry init functions , and also draw function in PieChartRenderer class to place the image and label in the right position.