Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run view port jobs afterwards (Fixes #2395) #2396

Merged
merged 1 commit into from
May 1, 2017
Merged

Run view port jobs afterwards (Fixes #2395) #2396

merged 1 commit into from
May 1, 2017

Commits on Apr 26, 2017

  1. Run view port jobs afterwards (Fixes #2395) 

    `notifyDataSetChanged()` may actually mutate some of the view port properties — stomping all over what the view port jobs just accomplished.

This behavior is apparent when calling `moveViewToX()` on the chart view that has no frame yet. Prior to this change, calling `moveViewToX()` had no affect on a chart a chart that has no frame. That's because once the chart view was assigned a frame, `notifyDataSetChanged()` call would actually mutate the view port's properties stomping all over what the view port jobs just finished doing.
    @feosuna1
    feosuna1 committed Apr 26, 2017
    Configuration menu
    Copy the full SHA
    b03f555 View commit details
    Browse the repository at this point in the history