Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected multiple comments to use correct Swift syntax #2399

Closed
wants to merge 1 commit into from

Conversation

elaewin
Copy link
Contributor

@elaewin elaewin commented Apr 27, 2017

Multiple comments in multiple files were commented with a triple slash (///) which is the correct syntax for C#, but not for Swift. This was causing multiple warnings in Xcode.

A slash was removed where necessary to give the comments the correct double slash syntax for Swift comments.

…ather than double slash // that was causing multiple warnings in Xcode.
@codecov-io
Copy link

Codecov Report

Merging #2399 into master will not change coverage.
The diff coverage is 21.27%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2399   +/-   ##
=======================================
  Coverage   19.66%   19.66%           
=======================================
  Files         112      112           
  Lines       13712    13712           
=======================================
  Hits         2696     2696           
  Misses      11016    11016
Impacted Files Coverage Δ
Source/Charts/Renderers/BarChartRenderer.swift 41.78% <ø> (ø) ⬆️
Source/Charts/Renderers/PieChartRenderer.swift 0% <ø> (ø) ⬆️
Source/Charts/Components/ChartLimitLine.swift 0% <ø> (ø) ⬆️
Source/Charts/Highlight/Highlight.swift 0% <ø> (ø) ⬆️
Source/Charts/Utils/ChartUtils.swift 35.21% <ø> (ø) ⬆️
Source/Charts/Renderers/RadarChartRenderer.swift 0% <ø> (ø) ⬆️
...rts/Renderers/LineScatterCandleRadarRenderer.swift 9.09% <ø> (ø) ⬆️
Source/Charts/Highlight/Range.swift 0% <ø> (ø) ⬆️
...ta/Implementations/Standard/LineChartDataSet.swift 22.38% <ø> (ø) ⬆️
...Data/Implementations/Standard/RadarChartData.swift 0% <ø> (ø) ⬆️
... and 71 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5288c25...ce7bf0e. Read the comment docs.

@thierryH91200
Copy link
Contributor

thierryH91200 commented Apr 27, 2017

are you sure ?????

on a function with Xcode
capture d ecran 2017-04-27 a 20 12 23

and the result
capture d ecran 2017-04-27 a 20 12 34

on playground
type

/// This is an awesome documentation line for a really useful variable.
var someVar = "This is a variable"

Option/Alt-Clicking to the name of a property, method, class,

capture d ecran 2017-04-27 a 21 13 02

@elaewin
Copy link
Contributor Author

elaewin commented Apr 27, 2017

The triple slashes for document markup are what is causing the errors in issues #135, and #2316.

@elaewin elaewin closed this Apr 27, 2017
@elaewin elaewin deleted the elaewin-commentsFixes branch April 27, 2017 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants