Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add multi axis #2477

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

add multi axis #2477

wants to merge 8 commits into from

Conversation

thierryH91200
Copy link
Contributor

I needed 4 axes because I had data in very different scales and the problem to internationalize the data implied great variations
Celcius in farenheit
Miles in km
The variations were not compatible with 2 axes and 4 curves
As I knew it did not exist it's done
Now for me it's ok otherwise it has not been easy

capture d ecran 2017-05-25 a 18 47 19

capture d ecran 2017-05-25 a 17 57 41

capture d ecran 2017-05-25 a 17 56 41

@liuxuan30
Copy link
Member

Where is @danielgindi 😂 Someone is pulling features and pending

@thierryH91200
Copy link
Contributor Author

thierryH91200 commented May 26, 2017

I forgot the use of: extraTopOffset, extraBottomOffset, extraLeftOffset, extraRightOffset
sorry

@thierryH91200
Copy link
Contributor Author

Request help

I have a little problem
let me explain
Charts consists of a graph and these components

  • Legend
  • LimitLine
  • Description
  • Marker
  • xAxis
  • yAxis
  • _pinchGestureRecognizer
  • _panGestureRecognizer
  • etc ....

On my side I have added 2 secondary axes

The problem is that all these components are true by default. Is that it would have been better if some were true and some false by default and the user adds these components one by one or removes them

Open class ComponentBase: NSObject
{

// flag that indicates if this component is enabled or not
Open var enabled = true

Open var isEnabled: Bool {return enabled}
}

I would like the 2 secondary axes to be false by default, but I can not use anything other than enabled and isEnabled, as it is a component

Otherwise adding a variable of the type "axisSecondaryEnabled" this causes to modify a lot of code in many class

  • YAxisRenderer
  • YAxisRendererHorizontalBarChart
  • BarLineChartViewBase
  • etc

I do not know what to do

  • many code changes but nothing is impossible with a risk of error
  • do you have another great idea that I did not think ??

@thierryH91200
Copy link
Contributor Author

update with axisSecondaryEnabled = false
enabled is not used

@LucaFagan
Copy link

I also need this feature. When will it available?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants