Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conform to macOS api changes in swift 3.2 #2717

Merged
merged 1 commit into from
Sep 3, 2017
Merged

Conform to macOS api changes in swift 3.2 #2717

merged 1 commit into from
Sep 3, 2017

Conversation

ohbargain
Copy link
Contributor

Compiling the framework with Xcode 9 beta 4 results in error due to macOS Swift api changes.
This pull request resolves that.

@codecov-io
Copy link

Codecov Report

Merging #2717 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2717   +/-   ##
=======================================
  Coverage   19.65%   19.65%           
=======================================
  Files         112      112           
  Lines       13717    13717           
=======================================
  Hits         2696     2696           
  Misses      11021    11021
Impacted Files Coverage Δ
Source/Charts/Utils/Platform.swift 13.33% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e72f280...7635f5f. Read the comment docs.

@liuxuan30
Copy link
Member

We will hold all Xcode 9 PRs after it's released.

@liuxuan30 liuxuan30 self-assigned this Aug 21, 2017
@pmairoldi
Copy link
Collaborator

in xcode 9 beta 6 there is no warnings but there this is more swifty.

@pmairoldi pmairoldi merged commit d7dc8f0 into ChartsOrg:master Sep 3, 2017
PeterSrost pushed a commit to sokol8/Charts that referenced this pull request Oct 31, 2018
Conform to macOS api changes in swift 3.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants