Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solved XCode7 abort trap:6 bug #274

Closed
wants to merge 8 commits into from
Closed

Solved XCode7 abort trap:6 bug #274

wants to merge 8 commits into from

Conversation

eldafito
Copy link

@eldafito eldafito commented Aug 4, 2015

Archiving the project in XCode 7 does not throw compiler exception
anymore

danielgindi and others added 8 commits July 26, 2015 23:08
- Failable initializers can’t override non-failable initializers
- observeValueForKeyPath’s signature didn’t match the signature of the
method it was overriding
Archiving the project in XCode 7 does not throw compiler exception
anymore
@liuxuan30
Copy link
Member

Could share why you make the changes this way? What's the difference here. BTW, the coding style is not identical to others, especially where you put '{}'

@pmairoldi
Copy link
Collaborator

It's a compiler bug. Here is a radar explaining it. http://www.openradar.me/22138918

@danielgindi
Copy link
Collaborator

Hi!
Thanks for sharing!
There are two problems:

  1. The codestyling in your code does not match the code style of the library, and specifically changes existing code to a different, unreadable code style.
  2. This is a compiler bug in a beta Xcode version, which should be actually fixed by Apple in the next betas...

@eldafito
Copy link
Author

eldafito commented Aug 5, 2015

I can change the codestyling or, if not interested, I'll close the request.

@danielgindi
Copy link
Collaborator

Let's wait a little for Xcode 7 beta 5 - see if it is fixed. If Apple does not handle that then we'll have to make the workarounds...

@eldafito
Copy link
Author

eldafito commented Aug 5, 2015

ok

@pmairoldi
Copy link
Collaborator

I actually like this syntax better. It is very clear what the edge conditions are and the variable is only set once so it's easier to follow the assignment.

@danielgindi
Copy link
Collaborator

We could change the flow to this kind of flow as a refactoring commit....
But it must be clean, not a degradation in quality :-)

On Wed, Aug 5, 2015 at 5:31 PM, Pierre-Marc Airoldi <
notifications@github.com> wrote:

I actually like this syntax better. It is very clear what the edge
conditions are and the variable is only set once so it's easier to follow
the assignment.


Reply to this email directly or view it on GitHub
#274 (comment)
.

@danielgindi
Copy link
Collaborator

Anyone knows if this was fixed in Xcode 7 beta 5?

@pmairoldi
Copy link
Collaborator

yes it is. tried the code in the radar on beta-4 and it failed. Beta 5 it compiled fine. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants