Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom text alignment for no data case #2800

Closed
wants to merge 1 commit into from

Conversation

Browncoat
Copy link

@Browncoat Browncoat commented Sep 19, 2017

Add NSTextAlignment option to noDataText to allow for custom text alignment

@jjatie jjatie changed the title Add NSTextAlignment option to noDataText to allow for custom text alignment Custom text alignment for no data case Jan 6, 2018
@jjatie
Copy link
Collaborator

jjatie commented Jan 12, 2018

@liuxuan30 This seems like a good an improvement. Do you think we should accept it?

@liuxuan30
Copy link
Member

sure. @Browncoat let's fix the conflict and follow the code style

@jjatie jjatie added this to the 3.1 milestone Jan 15, 2018
@jjatie jjatie closed this Jan 21, 2018
@ChartsOrg ChartsOrg locked and limited conversation to collaborators Jan 21, 2018
@jjatie jjatie removed the In review label Jan 21, 2018
@jjatie jjatie removed this from the 3.1 milestone Jan 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants