Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adhere to axis dependencies on combined charts #2870

Closed
wants to merge 1 commit into from

Conversation

mihahribar
Copy link

@mihahribar mihahribar commented Oct 12, 2017

@codecov-io
Copy link

Codecov Report

Merging #2870 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2870      +/-   ##
==========================================
- Coverage   19.64%   19.63%   -0.01%     
==========================================
  Files         113      113              
  Lines       13792    13798       +6     
==========================================
  Hits         2709     2709              
- Misses      11083    11089       +6
Impacted Files Coverage Δ
...a/Implementations/Standard/CombinedChartData.swift 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8245f32...b9a4e05. Read the comment docs.

@liuxuan30
Copy link
Member

liuxuan30 commented Oct 13, 2017

Sorry that issue has been a long time and I don't recall a lot. I will revisit this and handle it.
BTW, #2433, #2049 was a PR already.

@liuxuan30 liuxuan30 self-assigned this Oct 13, 2017
@liuxuan30 liuxuan30 closed this Oct 13, 2017
@mihahribar
Copy link
Author

mihahribar commented Oct 13, 2017

No problem. Am currently using my own fork but will update once other PRs are closed. Thanks for taking the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants