Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give the users customizable axis label limits (Fixes #2085) #2894

Merged
merged 2 commits into from
Jan 9, 2018
Merged

Give the users customizable axis label limits (Fixes #2085) #2894

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c615004
Give the users customizable axis label limits (Fixes #2085)
igzrobertoestrada Oct 13, 2017
d26acd0
Type inference was enough to declare 'axisMinLabels' and 'axisMaxLabe…
igzrobertoestrada Jan 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Source/Charts/Components/AxisBase.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,12 +214,12 @@ open class AxisBase: ComponentBase
@objc open var axisRange = Double(0)

/// The minumum number of labels on the axis
@objc open var axisMinLabels: Int = Int(2) {
@objc open var axisMinLabels = Int(2) {
didSet { axisMinLabels = axisMinLabels > 0 ? axisMinLabels : oldValue }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we use didSet or setter for this check here? @jjatie

}

/// The maximum number of labels on the axis
@objc open var axisMaxLabels: Int = Int(25) {
@objc open var axisMaxLabels = Int(25) {
didSet { axisMinLabels = axisMaxLabels > 0 ? axisMaxLabels : oldValue }
}

Expand Down