Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for iPhone X #2967

Merged
merged 2 commits into from
Nov 8, 2017
Merged

Add support for iPhone X #2967

merged 2 commits into from
Nov 8, 2017

Conversation

liuxuan30
Copy link
Member

@liuxuan30 liuxuan30 commented Nov 8, 2017

adopted safe area for demo chart controllers;
remove launch image, use launch screen storyboard instead

Note:
I don't apply all constraints to safe area, only for those that will violate the guidelines. For example, slider Y has a decent distance to its super view, so changing to safe area is not a must.

…ption for new device screen (iPhone X)

2. add 1024 artwork to remove warning
@codecov-io
Copy link

codecov-io commented Nov 8, 2017

Codecov Report

Merging #2967 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2967   +/-   ##
=======================================
  Coverage   19.64%   19.64%           
=======================================
  Files         113      113           
  Lines       13792    13792           
=======================================
  Hits         2709     2709           
  Misses      11083    11083

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98552bb...f00f9de. Read the comment docs.

@liuxuan30
Copy link
Member Author

liuxuan30 commented Nov 8, 2017

CI is fine to merge for old models. I played a little with iPhone X, it's should be fine :)
(the simulator)

@liuxuan30 liuxuan30 merged commit ecba1da into master Nov 8, 2017
@liuxuan30 liuxuan30 deleted the iPhoneX branch November 8, 2017 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants