Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed isKind(of:) #3044

Merged
merged 1 commit into from
Dec 5, 2017
Merged

Removed isKind(of:) #3044

merged 1 commit into from
Dec 5, 2017

Conversation

jjatie
Copy link
Collaborator

@jjatie jjatie commented Nov 23, 2017

in favour of the Swift is

in favour of the Swift `is`
@jjatie
Copy link
Collaborator Author

jjatie commented Nov 23, 2017

The uses of isKind(of:) in the equality methods are taken care of in #3002

@codecov-io
Copy link

Codecov Report

Merging #3044 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3044      +/-   ##
==========================================
+ Coverage   19.77%   19.78%   +<.01%     
==========================================
  Files         113      113              
  Lines       13663    13660       -3     
==========================================
  Hits         2702     2702              
+ Misses      10961    10958       -3
Impacted Files Coverage Δ
Source/Charts/Charts/BarLineChartViewBase.swift 23.17% <0%> (+0.06%) ⬆️
Source/Charts/Charts/PieRadarChartViewBase.swift 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc40b16...c7a1c04. Read the comment docs.

@jjatie
Copy link
Collaborator Author

jjatie commented Nov 24, 2017

@liuxuan30 This is a quick and easy one.

@liuxuan30
Copy link
Member

sorry, had a busy week. I will try finish some

@liuxuan30 liuxuan30 merged commit 19da2c0 into ChartsOrg:master Dec 5, 2017
@jjatie jjatie deleted the iskind-of branch December 5, 2017 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants