Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fill rewrite #3084

Merged
merged 7 commits into from
Apr 16, 2020
Merged

Fill rewrite #3084

merged 7 commits into from
Apr 16, 2020

Commits on Dec 11, 2017

  1. Fill is now a protocol 

    Different fill logic is broken up into separate classes. This has a few benefits:
1. It makes the `Fill` types more readable (logic is grouped together)
2. No optionals
3. Most importantly it allows consumers to create new Fill types without looking into the framework.
    @jjatie
    jjatie committed Dec 11, 2017
    Configuration menu
    Copy the full SHA
    bd078b9 View commit details
    Browse the repository at this point in the history

  2. Added super.init() for objc

    @jjatie
    jjatie committed Dec 11, 2017
    Configuration menu
    Copy the full SHA
    8a79890 View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2017

  1. Merge remote-tracking branch 'upstream/4.0.0' into fill-rewrite

    Jacob Christie committed Dec 27, 2017
    Configuration menu
    Copy the full SHA
    0e73c4d View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2019

  1. Updated Fill access 

    No need to subclass existing fills now that the system is more flexible. If functionality is needed from another fill, user can call it within their own `fillPath(context: CGContext, rect: CGRect)` implementation.
    @jjatie
    jjatie committed Jan 13, 2019
    Configuration menu
    Copy the full SHA
    447bf7d View commit details
    Browse the repository at this point in the history

  2. Merge branch '4.0.0' into fill-rewrite

    @jjatie
    jjatie committed Jan 13, 2019
    Configuration menu
    Copy the full SHA
    a1c6f4e View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2019

  1. Updated Fill Names

    @jjatie
    jjatie committed Mar 9, 2019
    Configuration menu
    Copy the full SHA
    9191283 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2020

  1. Update Fill.swift 

    update code style
    @liuxuan30
    liuxuan30 committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    e4c65bb View commit details
    Browse the repository at this point in the history