Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subclassing of LegendRenderer didn't take any effect #3149

Merged
merged 1 commit into from
Jan 8, 2018
Merged

Subclassing of LegendRenderer didn't take any effect #3149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Source/Charts/Charts/BarLineChartViewBase.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@ open class BarLineChartViewBase: ChartViewBase, BarLineScatterCandleBubbleChartD

if _legend !== nil
{
_legendRenderer?.computeLegend(data: data)
legendRenderer?.computeLegend(data: data)
}
}

Expand Down
2 changes: 1 addition & 1 deletion Source/Charts/Charts/PieChartView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ open class PieChartView: PieRadarChartViewBase

renderer.drawValues(context: context)

_legendRenderer.renderLegend(context: context)
legendRenderer.renderLegend(context: context)

drawDescription(context: context)

Expand Down
2 changes: 1 addition & 1 deletion Source/Charts/Charts/PieRadarChartViewBase.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ open class PieRadarChartViewBase: ChartViewBase

if let data = _data , _legend !== nil
{
_legendRenderer.computeLegend(data: data)
legendRenderer.computeLegend(data: data)
}

calculateOffsets()
Expand Down
4 changes: 2 additions & 2 deletions Source/Charts/Charts/RadarChartView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ open class RadarChartView: PieRadarChartViewBase
let legend = _legend,
!legend.isLegendCustom
{
_legendRenderer?.computeLegend(data: data)
legendRenderer?.computeLegend(data: data)
}

calculateOffsets()
Expand Down Expand Up @@ -139,7 +139,7 @@ open class RadarChartView: PieRadarChartViewBase

renderer.drawValues(context: context)

_legendRenderer.renderLegend(context: context)
legendRenderer.renderLegend(context: context)

drawDescription(context: context)

Expand Down