Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor bug fix in favor of 3.1 release #3312

Merged
merged 2 commits into from
Mar 4, 2018
Merged

minor bug fix in favor of 3.1 release #3312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60c5c10
revert a mistake, fix #3299
liuxuan30 Mar 2, 2018
df018a4
fix #3311. Need one more key for iOS 11 camera roll saving
liuxuan30 Mar 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ChartsDemo/Supporting Files/Info.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
<string>1</string>
<key>LSRequiresIPhoneOS</key>
<true/>
<key>NSPhotoLibraryAddUsageDescription</key>
<string>This app requires access to the photo library to store shots of charts there.</string>
<key>NSPhotoLibraryUsageDescription</key>
<string>This app requires access to the photo library to store shots of charts there.</string>
<key>UILaunchStoryboardName</key>
Expand Down
4 changes: 2 additions & 2 deletions Source/Charts/Jobs/ZoomViewJob.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@ open class ZoomViewJob: ViewPortJob
let xValsInView = (view as! BarLineChartViewBase).xAxis.axisRange / Double(viewPortHandler.scaleX)

var pt = CGPoint(
x: CGFloat(xValue - xValsInView) / 2.0,
y: CGFloat(yValue + yValsInView) / 2.0
x: CGFloat(xValue - xValsInView / 2.0),
y: CGFloat(yValue + yValsInView / 2.0)
)

transformer.pointValueToPixel(&pt)
Expand Down