Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift 4.1 #3370

Merged
merged 5 commits into from
Mar 30, 2018
Merged

Swift 4.1 #3370

merged 5 commits into from
Mar 30, 2018

Conversation

jjatie
Copy link
Collaborator

@jjatie jjatie commented Mar 30, 2018

Moved to Swift 4.1 and Xcode 9.3

@jjatie
Copy link
Collaborator Author

jjatie commented Mar 30, 2018

@liuxuan30 Here is the Swift 4.1 update. You can bump to Charts 3.1.1 now

@jjatie jjatie merged commit b40aa1b into master Mar 30, 2018
@jjatie jjatie deleted the swift-4.1 branch March 30, 2018 13:04
@FleetPhil
Copy link

Sorry if I'm being a dumb newbie, but when I run 'pod update' for Charts it pulls version 3.1.0 and I still have the compilation warnings about ! and flatMap. If I edit the podfile to try and force version 3.1.1 it says it does not exist. Am I doing something wrong?

@jjatie
Copy link
Collaborator Author

jjatie commented Mar 31, 2018

The pod hasn't been updated yet. 3.1.1 will be out when @liuxuan30 has time.

@FleetPhil
Copy link

Ah! That would explain it! Thanks

@liuxuan30
Copy link
Member

sure. Thanks. I will handle maybe tomorrow.

@liuxuan30 liuxuan30 self-assigned this Apr 2, 2018
@@ -1,12 +1,12 @@
language: objective-c
osx_image: xcode9
osx_image: xcode9.3beta
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

travis still in 9.3beta?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should drop the "beta", but it will work for now.

@@ -1045,7 +1051,7 @@
IPHONEOS_DEPLOYMENT_TARGET = 9.0;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
PRODUCT_BUNDLE_IDENTIFIER = "com.dcg.$(PRODUCT_NAME:rfc1034identifier)";
PRODUCT_NAME = ChartsDemo;
PRODUCT_NAME = "ChartsDemo-iOS";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did we changed the project strut, by purpose or accident?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On purpose. Some naming was out of date, or inconsistent (macOS vs OS X).

@@ -1691,12 +1691,12 @@ open class BarLineChartViewBase: ChartViewBase, BarLineScatterCandleBubbleChartD
}

/// - returns: The DataSet object displayed at the touched position of the chart
@objc open func getDataSetByTouchPoint(point pt: CGPoint) -> IBarLineScatterCandleBubbleChartDataSet!
@objc open func getDataSetByTouchPoint(point pt: CGPoint) -> IBarLineScatterCandleBubbleChartDataSet?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this warned by Xcode 9.3? or why we change

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's never been correct to use IUO as a return type or parameter type. This is deprecated in 4.1 and will be an error in a future release. SE-0054, SR-3023

@@ -0,0 +1,8 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this file

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Xcode 9.3 adds a new IDEWorkspaceChecks.plist file to a workspace's shared data, to store the state of necessary workspace checks. Committing this file to source control will prevent unnecessary rerunning of those checks for each user opening the workspace. (37293167)

CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
CLANG_WARN_EMPTY_BODY = YES;
CLANG_WARN_ENUM_CONVERSION = YES;
CLANG_WARN_INFINITE_RECURSION = YES;
CLANG_WARN_INT_CONVERSION = YES;
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this added by xcode automatically?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New Xcode recommended settings

@liuxuan30
Copy link
Member

good. I'm pushing 3.1.1 to pod now

@FleetPhil
Copy link

Looks good, many thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants