Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the error title for demo #3528

Merged
merged 1 commit into from
Jul 11, 2018
Merged

Conversation

yangasahi
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Jun 24, 2018

Codecov Report

Merging #3528 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3528   +/-   ##
=======================================
  Coverage   29.94%   29.94%           
=======================================
  Files         118      118           
  Lines       13793    13793           
=======================================
  Hits         4130     4130           
  Misses       9663     9663

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fafd58c...5d9860f. Read the comment docs.

@@ -28,7 +28,7 @@ - (void)viewDidLoad
{
[super viewDidLoad];

self.title = @"Pie Bar Chart";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petester42 @jjatie need some advise on the name. Pie Bar Chart is ok or kind of typo ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO
"Pie Chart" is better.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would agree. It's more clear.

@@ -28,7 +28,7 @@ - (void)viewDidLoad
{
[super viewDidLoad];

self.title = @"Pie Bar Chart";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would agree. It's more clear.

@@ -21,7 +21,7 @@ class PieChartViewController: DemoBaseViewController {
super.viewDidLoad()

// Do any additional setup after loading the view.
self.title = "Half Pie Bar Chart"
self.title = "Pie Chart"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep the 'half' word?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the "Pie Chart" is correct since the controller name is "PieChartViewController".
BTW, I have fixed the title to "Half Pie Chart" from "Half Pie Bar Chart" for "HalfPieChartViewController.swift"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see.

@@ -21,7 +21,7 @@ class PieChartViewController: DemoBaseViewController {
super.viewDidLoad()

// Do any additional setup after loading the view.
self.title = "Half Pie Bar Chart"
self.title = "Pie Chart"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see.

@liuxuan30
Copy link
Member

Thanks!

@liuxuan30 liuxuan30 merged commit 61eb6e6 into ChartsOrg:master Jul 11, 2018
@yangasahi yangasahi deleted the demo_title_fix branch July 11, 2018 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants