Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make NSUIAccessibilityElement initializer public. #3654

Merged
merged 1 commit into from
Oct 21, 2018
Merged

Make NSUIAccessibilityElement initializer public. #3654

merged 1 commit into from
Oct 21, 2018

Conversation

417-72KI
Copy link
Contributor

Issue Link 🔗

When I create custom renderer with overriding LineChartRenderer, I can't create NSUIAccessibilityElement instance because its initializer is not public!
image

Furthermore, although NSUIAccessibilityElement is defined as open class, its subclass can create no instance.
image

Goals ⚽

To be able to create NSUIAccessibilityElement instance outside Charts.framework.

Implementation Details 🚧

  • Added public modifier to NSUIAccessibilityElement.init(accessibilityContainer:).

Testing Details 🔍

None, there are no specific tests.
This should not effect the snapshotting at all, and has no effect on the existing codebase.

@codecov-io
Copy link

Codecov Report

Merging #3654 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3654   +/-   ##
=======================================
  Coverage   31.06%   31.06%           
=======================================
  Files         114      114           
  Lines       10465    10465           
=======================================
  Hits         3251     3251           
  Misses       7214     7214
Impacted Files Coverage Δ
Source/Charts/Utils/Platform+Accessibility.swift 31.57% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5087a04...3d40b00. Read the comment docs.

@@ -33,7 +33,7 @@ open class NSUIAccessibilityElement: UIAccessibilityElement
}
}

override init(accessibilityContainer container: Any)
override public init(accessibilityContainer container: Any)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we change it to open? @petester42 @jjatie

@pmairoldi
Copy link
Collaborator

I’ll look into it. Anything that is nsui prefixed is usually just for internal use since it’s platform dependent switch to have to same API. I’m hesitant to merge because it should be internal only.

@pmairoldi
Copy link
Collaborator

After some thought. I can see the usefulness of this to be public.

3 similar comments
@pmairoldi
Copy link
Collaborator

After some thought. I can see the usefulness of this to be public.

@pmairoldi
Copy link
Collaborator

After some thought. I can see the usefulness of this to be public.

@pmairoldi
Copy link
Collaborator

After some thought. I can see the usefulness of this to be public.

@pmairoldi pmairoldi merged commit 3b07904 into ChartsOrg:master Oct 21, 2018
@pmairoldi
Copy link
Collaborator

After some thought. I can see the usefulness of this to be public.

@ChartsOrg ChartsOrg deleted a comment from pmairoldi Oct 24, 2018
@417-72KI 417-72KI deleted the accesibility_element_initializer branch November 13, 2019 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants