Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lineJoinType and miterLimit parameters to LineChartDataSet (fixes #2180 ) #3797

Closed
wants to merge 1 commit into from
Closed

Add lineJoinType and miterLimit parameters to LineChartDataSet (fixes #2180 ) #3797

wants to merge 1 commit into from

Conversation

anton-filimonov
Copy link

let users fix sharp edges the way they want, keeping default behaviour same as current.

Issue Link 🔗

#2180

Implementation Details 🚧

There is another PR that is made to solve same issue but it changes the default behaviour and actually also breaks line joins when lineCapType is not .round. This PR is another way to solve that problem, but it also not ideal - multicolored line will not use introduced lineJoinType property because of tricky way to draw that line (actually that tricky way leads to bad line when lineCapType is not .round)

…et users fix issue with sharp edges the way they want
@codecov-io
Copy link

Codecov Report

Merging #3797 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3797      +/-   ##
==========================================
+ Coverage   32.67%   32.69%   +0.01%     
==========================================
  Files         114      114              
  Lines       10754    10757       +3     
==========================================
+ Hits         3514     3517       +3     
  Misses       7240     7240
Impacted Files Coverage Δ
...ta/Implementations/Standard/LineChartDataSet.swift 30% <ø> (ø) ⬆️
Source/Charts/Renderers/LineChartRenderer.swift 61.81% <100%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0749a2e...ab37306. Read the comment docs.

@liuxuan30
Copy link
Member

eh, is this PR exclusive to #3764? meaning we should only merge one of the two?

@anton-filimonov
Copy link
Author

anton-filimonov commented Dec 24, 2018

@liuxuan30 yes. Another one breaks line joins for single color line (for multicolored line it was broken long ago), so we have to choose only one of them

@liuxuan30
Copy link
Member

OK. Let's discuss in #3764 then to find a proper one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants