Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reassess convenience initializers #3862

Merged
merged 3 commits into from
Apr 12, 2019
Merged

Reassess convenience initializers #3862

merged 3 commits into from
Apr 12, 2019

Commits on Apr 11, 2019

  1. Reassess convenience initializers 

    The only data required to initialize an entry is an x and y value (or y in the case of Pie and Radar). All other data can easily be updated by initializing and assigning properties on the entry. Therefor, those initializers should be the ones marked as convenience.
Made initializer declarations consistent.
    @jjatie
    jjatie committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    d18a899 View commit details
    Browse the repository at this point in the history

  2. Modernize BarChartDataEntry internal calculations

    @jjatie
    jjatie committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    9f41250 View commit details
    Browse the repository at this point in the history

  3. Style updated for PR

    @jjatie
    jjatie committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    a155ab3 View commit details
    Browse the repository at this point in the history