Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix first value not display bug #3865

Closed
wants to merge 2 commits into from

Conversation

YusukeOba
Copy link
Contributor

Issue Link πŸ”—

#3857
#3848

Goals ⚽

Display first value in ChartView.

Implementation Details 🚧

I deferred increment.

Testing Details πŸ”

I tested in example demo and my project.

@codecov-io
Copy link

Codecov Report

Merging #3865 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3865   +/-   ##
=======================================
  Coverage   32.79%   32.79%           
=======================================
  Files         114      114           
  Lines       10731    10731           
=======================================
  Hits         3519     3519           
  Misses       7212     7212
Impacted Files Coverage Ξ”
...Renderers/BarLineScatterCandleBubbleRenderer.swift 81.25% <100%> (ΓΈ) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update cf36285...7ee29db. Read the comment docs.

@jjatie
Copy link
Collaborator

jjatie commented Mar 9, 2019

Resolved by #3891

@jjatie jjatie closed this Mar 9, 2019
@ChartsOrg ChartsOrg locked as resolved and limited conversation to collaborators Mar 9, 2019
@YusukeOba YusukeOba deleted the fix_#3857 branch March 11, 2019 02:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants