Update Charts for Swift 5 compiler

[alanzeino]

Goals ⚽

Swift 5 compiler warnings

[liuxuan30]

there is already #3874

[alanzeino]

there is already #3874

#3874 is not backwards compatible with Swift 4.2. I think my change is the correct one and should be merged.

[liuxuan30]

@alanzeino thanks for pointing out the difference, I think @jjatie could work with you to address your issues in that PR. I'm ok to either reopen yours and close #3874.

[alanzeino]

@alanzeino thanks for pointing out the difference, I think @jjatie could work with you to address your issues in that PR. I'm ok to either reopen yours and close #3874.

I'll wait for @jjatie to comment, but this PR is thorough and complete and can be merged now. I also have another change to include in this PR but can't right now as it is closed.

[liuxuan30]

@jjatie what you think?
@alanzeino he may be busy with this work. so let's wait.

[jjatie]

I don't see any reason to have this merged now. Swift 5 is not out yet, and we have yet to support previous versions of Swift through availability checks. Until module stability is locked in for Apple platforms, there isn't a strong reason to either.

[alanzeino]

I don't see any reason to have this merged now. Swift 5 is not out yet, and we have yet to support previous versions of Swift through availability checks. Until module stability is locked in for Apple platforms, there isn't a strong reason to either.

@jjatie Swift 5 and Xcode 10.2 are about a week or two away but if you want to wait that’s fine.

_{Sent with GitHawk}