Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Xcode 11 errors in SPM project #4048

Closed
wants to merge 1 commit into from

Conversation

dstranz
Copy link
Contributor

@dstranz dstranz commented Jun 28, 2019

Goals ⚽

  • Fix build errors in SPM project

Zrzut ekranu 2019-06-28 o 16 05 00

Implementation Details 🚧

  • Add missing imports

Testing Details 🔍

  • Open Package.swift file in Xcode 11

@codecov-io
Copy link

codecov-io commented Jun 28, 2019

Codecov Report

Merging #4048 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4048   +/-   ##
=======================================
  Coverage   40.14%   40.14%           
=======================================
  Files         119      119           
  Lines       13985    13985           
=======================================
  Hits         5614     5614           
  Misses       8371     8371
Impacted Files Coverage Δ
...rce/Charts/Renderers/YAxisRendererRadarChart.swift 0% <ø> (ø) ⬆️
Source/Charts/Utils/ChartUtils.swift 57.51% <ø> (ø) ⬆️
Source/Charts/Charts/PieChartView.swift 58.98% <ø> (ø) ⬆️
Source/Charts/Components/MarkerView.swift 0% <ø> (ø) ⬆️
Source/Charts/Renderers/PieChartRenderer.swift 51.38% <ø> (ø) ⬆️
Source/Charts/Utils/Platform+Accessibility.swift 37.93% <ø> (ø) ⬆️
Source/Charts/Jobs/AnimatedViewPortJob.swift 0% <ø> (ø) ⬆️
Source/Charts/Charts/BarLineChartViewBase.swift 25.81% <ø> (ø) ⬆️
Source/Charts/Charts/PieRadarChartViewBase.swift 19.95% <ø> (ø) ⬆️
Source/Charts/Components/YAxis.swift 91.89% <ø> (ø) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e850593...23ea152. Read the comment docs.

@thierryH91200
Copy link
Contributor

thierryH91200 commented Jun 29, 2019

import Foundation is useless it's in AppKIt and UIKit

import CoreGraphics
 
#if canImport(AppKit)
import AppKit
#else
import UIKit
#endif

import Foundation
import UIKit.DocumentManager
import UIKit.NSAttributedString
import UIKit.NSDataAsset
import UIKit.NSFileProviderExtension
import UIKit.NSIndexPath_UIKitAdditions
import UIKit.NSItemProvider_UIKitAdditions

and

import AppKit.NSWindow
import AppKit.NSWindowController
import AppKit.NSWindowRestoration
import AppKit.NSWindowScripting
import AppKit.NSWindowTab
import AppKit.NSWindowTabGroup
import AppKit.NSWorkspace
import Foundation

@liuxuan30
Copy link
Member

dup to #4017

@liuxuan30 liuxuan30 closed this Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants