Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #4099: Line renderer did not render lines if their coordinates fell outside of the viewport. #4100

Merged
merged 7 commits into from
Oct 9, 2019
Merged

Fixes #4099: Line renderer did not render lines if their coordinates fell outside of the viewport. #4100

merged 7 commits into from
Oct 9, 2019

Commits on Aug 8, 2019

  1. Fixed ChartsOrg#4099: Line renderer did not render lines if they coor… 

    …dinates fell outside of the viewport, even though they might intersect the viewport.
    @4np
    4np committed Aug 8, 2019
    Configuration menu
    Copy the full SHA
    af3c727 View commit details
    Browse the repository at this point in the history

  2. Updated inline documentation.

    @4np
    4np committed Aug 8, 2019
    Configuration menu
    Copy the full SHA
    c1735be View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2019

  1. Merge branch 'master' into fix/4099-line-sections-disappear

    @4np
    4np committed Sep 26, 2019
    Configuration menu
    Copy the full SHA
    258547e View commit details
    Browse the repository at this point in the history

  2. Implemented code review feedback and removed unnecessary checks for p… 

    …erformance reasons.
    @4np
    4np committed Sep 26, 2019
    Configuration menu
    Copy the full SHA
    d7ad8c5 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2019

  1. Simplified and clarified the linear function to check for collisions … 

    …with the left, top and bottom edges of the view port, and commented out the unecessary logic that checks for collision with the right edge of the view port.
    @4np
    4np committed Sep 30, 2019
    Configuration menu
    Copy the full SHA
    ababe6f View commit details
    Browse the repository at this point in the history

  2. Updated in-line documentation.

    @4np
    4np committed Sep 30, 2019
    Configuration menu
    Copy the full SHA
    73d1aad View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2019

  1. Update ViewPortHandler.swift 

    add a check for vertical line and a few comments change
    @liuxuan30
    liuxuan30 committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    a84b379 View commit details
    Browse the repository at this point in the history