SPM support for iOS, macOS, tvOS #4118
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4118 +/- ##
======================================
Coverage 41.5% 41.5%
======================================
Files 119 119
Lines 13992 13992
======================================
Hits 5807 5807
Misses 8185 8185
Continue to review full report at Codecov.
|
|
refer #4017 We only need one, can you guys work together, or which one is slightly better to merge? |
|
@Ragnalorn |
|
Thank you for your effort. We have merged the other one, so closing this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Swift Package Manager for Xcode11 can only build static libraries. This means that UIKit can't be linked dynamically, so we need to check if UIKit is available and import it if possible. “canImport” is available from Swift 4.1, so these changes won’t cause any compiling issues and everything will work correctly (Carthage, Pods, etc). Since it's CRITICAL to make this lib Swift Package Manager compatible for appleOS platforms, could you please merge this pull request as soon as possible?