Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve swift warnings that data was never mutated. #4141

Closed

Conversation

Tanaschita
Copy link

No description provided.

@codecov-io
Copy link

codecov-io commented Sep 11, 2019

Codecov Report

Merging #4141 into master will not change coverage.
The diff coverage is 85.71%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4141   +/-   ##
=======================================
  Coverage   41.49%   41.49%           
=======================================
  Files         119      119           
  Lines       13995    13995           
=======================================
  Hits         5807     5807           
  Misses       8188     8188
Impacted Files Coverage Δ
...rce/Charts/Renderers/YAxisRendererRadarChart.swift 0% <0%> (ø) ⬆️
...ce/Charts/Renderers/CandleStickChartRenderer.swift 0% <0%> (ø) ⬆️
Source/Charts/Renderers/LineChartRenderer.swift 65.57% <100%> (ø) ⬆️
Source/Charts/Renderers/PieChartRenderer.swift 68.93% <100%> (ø) ⬆️
.../Charts/Renderers/HorizontalBarChartRenderer.swift 72.24% <100%> (ø) ⬆️
Source/Charts/Renderers/BarChartRenderer.swift 74.61% <100%> (ø) ⬆️
Source/Charts/Renderers/LegendRenderer.swift 61.09% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e93bfb9...f38ab98. Read the comment docs.

@liuxuan30
Copy link
Member

Thanks!
this should be addressed in #4153.

@liuxuan30 liuxuan30 closed this Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants