Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performed recommended localization and internationalization changes. #4162

Merged
merged 1 commit into from
Nov 13, 2019

Conversation

coltonlemmon
Copy link
Contributor

Goals ⚽

This PR updates the project to the recommended settings for Xcode 11 and Swift 5.1 including the recommended localization and internationalization changes.

@codecov-io
Copy link

codecov-io commented Oct 1, 2019

Codecov Report

Merging #4162 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4162   +/-   ##
=======================================
  Coverage   41.49%   41.49%           
=======================================
  Files         119      119           
  Lines       13996    13996           
=======================================
  Hits         5807     5807           
  Misses       8189     8189

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90e8cd0...7ba56d2. Read the comment docs.

@liuxuan30
Copy link
Member

thanks!

@liuxuan30 liuxuan30 merged commit 61ba666 into ChartsOrg:master Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants