changed to display leftAxis line even if it fills between two line gr… #4199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there, Sorry for the delay. But I'm feeling, you are filling all the contentRect, instead of the area between your lines, which seems not making sense. |
liuxuan30
requested changes
Jan 19, 2020
| @@ -181,7 +181,7 @@ open class BarLineChartViewBase: ChartViewBase, BarLineScatterCandleBubbleChartD | |||
|
|
|||
| // execute all drawing commands | |||
| drawGridBackground(context: context) | |||
|
|
|||
| renderer.drawData(context: context) | |||
There was a problem hiding this comment.
if you pull this up before clip, you would get multiple UT failures.
You have to restrict the filling area between the lines, not the whole chart.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…aphs.
Issue Link 🔗
#4037
Goals ⚽
The leftAxis line is displayed even if you fill between two line graphs.
Implementation Details 🚧
Changed timing to call
renderer.drawData (context: context)