Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

labelXOffset = 10 is default for radar chart only #4270

Merged
merged 1 commit into from
Jan 23, 2020

Conversation

danielgindi
Copy link
Collaborator

  • also consider other renderers

Fixes #3406

Issue Link πŸ”—

#3406

Goals ⚽

Extend the solution to not be a piece of dead code.

Implementation Details 🚧

Considering the new property in all YAxisRenderers, while correctly setting the default of 10 only to Radar charts.

Testing Details πŸ”

Visually, + CI.

+ also consider other renderers

Fixes #3406
@danielgindi danielgindi merged commit 697e7a3 into master Jan 23, 2020
@danielgindi danielgindi deleted the bugfix/labelXOffset branch January 24, 2020 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant