Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase iOS version to 9 in Package.swift #4399

Merged
merged 1 commit into from
Sep 21, 2020
Merged

Increase iOS version to 9 in Package.swift #4399

merged 1 commit into from
Sep 21, 2020

Conversation

Rubenfer
Copy link
Contributor

Fixes Xcode 12 beta warning: The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 14.0.99.

Fixes Xcode 12 beta warning: "The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 14.0.99."
@liuxuan30
Copy link
Member

liuxuan30 commented Jul 13, 2020

Approved. Let's move all Xcode12 related PRs into a single project and wait until Xcode12 GM release.

@gabors
Copy link

gabors commented Sep 20, 2020

@liuxuan30 When is this getting merged to master pls?

@liuxuan30
Copy link
Member

@gabors super busy recently. remind me why we need this PR?

@gabors
Copy link

gabors commented Sep 21, 2020

@liuxuan30 Xcode 12 doesn't support iOS 8 anymore, so we are seeing a build warning exactly like the OP was writing.

@liuxuan30 liuxuan30 merged commit 6654640 into ChartsOrg:master Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants