-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump travis ci to use xcode 12 #4476
Conversation
ios-snapshot-test-case is not updated so the binary framework failed. I checked there is no new update on their repo. So seems we have to build from scratch to avoid this at least for now |
@jjatie seems the problem is Carthage after changing to source compile. Carthage/Carthage#3019 there is a workaround mentioned here Workaround that works with both Xcode 11 and 12Works with all versions of Xcode 12 (except beta 1 and 2; but no-one should be using those anymore). Once XCFrameworks support lands in Carthage this workaround won’t be needed. However not that XCFrameworks puts some strict requirements on projects that most projects don’t comply with. Note: This is a change from before where the script excluded arm64 for simulators by individual Xcode 12 version. It now removes it from all Xcode 12 based builds. How to useSave the script (👇) to your project (e.g. as a carthage.sh file). Script
|
…e#3019 there is a workaround mentioned [here](Carthage/Carthage#3019 (comment)) making travis to build from carthage.sh until the root issue is fixed.
@jjatie I'm having a hard time on my side that most of the tests failed even in the Xcode itself. for example, the diff image on my side is (bold area is the image diff): I also roll back to my commit could you try it on your side to see what will happen? if you got similar issues like me, do you think this is a bug and we should report to apple, or we just recreate new images? |
I have made the image refresh a single commit so we can move on or revert. I'm really confused, but seems there is some hidden changes in the UIKit or CoreGraphics rendering component that causes the slight difference. |
let's move ahead |
This is just to bump travis to use the latest Swift compiler. Project changes for Xcode 12 will come in a separate PR