Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace FBSnapshotTestCase with pointfree/swift-snapshot-testing #4574

Merged
merged 9 commits into from
Feb 5, 2021

Conversation

jjatie
Copy link
Collaborator

@jjatie jjatie commented Feb 4, 2021

FBSnapshotTestCase is all but deprecated. pointfree's snapshotting library is an excellent replacement that's become a bit of a community standard for snapshot testing. This also removes our Carthage dependency for tests.

Use github actions for testing. They consistent run faster, require less setup and satisfy our needs.

@jjatie jjatie requested a review from liuxuan30 February 4, 2021 16:32
@jjatie jjatie merged commit eb73757 into master Feb 5, 2021
@jjatie jjatie deleted the migrate-testing-to-github-actions branch February 5, 2021 15:13
@liuxuan30
Copy link
Member

wow, thank you!!!

@liuxuan30
Copy link
Member

anything we need to keep in mind for this new framework? like a cheat sheet?

@jjatie
Copy link
Collaborator Author

jjatie commented Feb 19, 2021

Only issue I've run into (which is true in FBSnapshot too) is that Intel and Silicon Macs generate slightly different snapshots. I've written a method assertChartSnapshot that compares to different images based on platform architecture to accommodate this.

There are many more options for snapshotting available in the library, beyond just images. Their GitHub page references the videos where they walkthrough creating the framework and using it.

abhiramvadlapatla pushed a commit to abhiramvadlapatla/Charts that referenced this pull request Dec 21, 2021
…rtsOrg#4574)

* Replace FBSnapshotTestCase with pointfree/SnapshotTesting

Use github actions for testing

* Added iOS Snapshots

* Update tests for SPM

* Add snapshots for x86 and Silicon

* Use Charts scheme for testing

* Remove Carthage search paths

* Fix x86 snapshots directory name

* Clean iOS and tvOS tests before testing

* Added action for building the iOS demo
zebraciam added a commit to zebraciam/Charts that referenced this pull request Jul 6, 2022
* master:
  update changelog.
  Fixed incorrect guard return statement when rendering limit lines (ChartsOrg#4563)
  Fix bounds checks on binary search (ChartsOrg#4577)
  Added SPM build action (ChartsOrg#4576)
  Replace FBSnapshotTestCase with pointfree/swift-snapshot-testing (ChartsOrg#4574)
  Import swift algorithms (ChartsOrg#4497)
  ChartViewBase cleanup (ChartsOrg#4537)
  SPM GitHub Action (ChartsOrg#4553)
  Algorithm updates (ChartsOrg#3638)
  Added SPM Install section
  Update README.md
  Fix missing drawIconsEnabled parameter initialization in the copying constructor of the ChartBaseDataSet (ChartsOrg#4424)
  Resolve conflict for 4.0 branch and master (ChartsOrg#4456)
  Alternative for SPM dynamic linking (ChartsOrg#4478)
  3.6.0 changelog

# Conflicts:
#	Source/Charts/Renderers/LineChartRenderer.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants