Fix for issue where data points are not highlighted #4613
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Link 🔗
Fixes #4609 and possibly also #4579
Goals ⚽
Improve the highlighting / selection behavior of line charts
Implementation Details 🚧
The
entriesForXValue
func finds the data entries for a given x-axisvalue. It used an optimization where it would do a binary search to find
the first matching entry then take a slice of data stopping when no more
entries matched.
The optimized code uses the
partitionIndex
function but the filter predicateused in this function was incorrect.
Testing Details 🔍
Tested by altering the demo project to use the forked version of the code and confirming the broken behaviour works after the fix is applied