Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue related to PhilJay/MPAndroidChart#1121 #488

Merged
merged 1 commit into from
Oct 21, 2015

Conversation

PhilJay
Copy link
Collaborator

@PhilJay PhilJay commented Oct 20, 2015

Setting default skip to 1 might result in unexpected behaviour.

@liuxuan30
Copy link
Member

commit 088b10d actually want it to be 1

@danielgindi
Copy link
Collaborator

If it will be zero then it will cause an infinite loop. Should be closed

@PhilJay
Copy link
Collaborator Author

PhilJay commented Oct 21, 2015

Should not cause infinite loop. You already fixed this: https://github.com/danielgindi/ios-charts/blob/master/Charts/Classes/Renderers/RadarChartRenderer.swift#L182

Currently it will (per default) skip 1 web line.

@danielgindi danielgindi reopened this Oct 21, 2015
@danielgindi
Copy link
Collaborator

Oh right. This property was very confusing to begin with...

danielgindi added a commit that referenced this pull request Oct 21, 2015
@danielgindi danielgindi merged commit 94e06ce into ChartsOrg:master Oct 21, 2015
@PhilJay
Copy link
Collaborator Author

PhilJay commented Oct 21, 2015

Yes it was :-)
I sure had my trouble with it :-D

@danielgindi
Copy link
Collaborator

Yeah there was a good reason why I wanted to change its behavior to not add/subtract the 1 on the property. There were many bugs and misunderstandings. I hope its stable now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants