Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if only line data exists and no other data, turn _deltaX to 1.0 #493

Merged
merged 1 commit into from
Oct 23, 2015

Conversation

liuxuan30
Copy link
Member

if only line data exists and no other data in combined chart, turn _deltaX to 1.0, just like what LineChartView did

This is for #329 and what @jwardle asked in my PR #269

danielgindi added a commit that referenced this pull request Oct 23, 2015
if only line data exists and no other data, turn _deltaX to 1.0
@danielgindi danielgindi merged commit 2ea751b into ChartsOrg:master Oct 23, 2015
@danielgindi
Copy link
Collaborator

Thanks! Please have your descriptions more to-the-point next time :-) It's hard to understand what the change actually does...

@liuxuan30
Copy link
Member Author

OK. The problem is sometimes there is only line chart data, no bubble, no bar, no candle. So the _deltaX is not correct. This fix it, taking example from LineChartView

@liuxuan30 liuxuan30 deleted the onlylineData branch October 26, 2015 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants