Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update library name #5009

Closed

Conversation

waterskier2007
Copy link

Issue Link #4845

Fixes naming conflict with Apple's Charts framework

Goals ⚽

Update the Swift package name
Update the podspec
Update the directory structure to match
Update the Charts xcode project to use a folder-based structure instead of Groups

Implementation Details 🚧

Implemented each step in a single commit so it's easier to follow

Testing Details 🔍

@liuxuan30
Copy link
Member

Thanks for your contritution! this is what we exactly needed!

however, UIChart seems unpossible since it's reserved by Apple already. Would mind change to DGCharts ?

@liuxuan30
Copy link
Member

let's make sure it biuld on xcode 14 as well

@rineek
Copy link

rineek commented Mar 8, 2023

Shouldn't the directory names also be updated from UICharts to DGCharts?

@waterskier2007
Copy link
Author

Wow, yep that was a big mistake on my part - updated.

@waterskier2007
Copy link
Author

I have also built and run this in a personal app targeting my fork and branch - on Xcode 14.2

@zygoat
Copy link

zygoat commented Mar 8, 2023

What about the xcodeproj and podspec filenames; wouldn't it be idiomatic for them to match the project name too?

@waterskier2007
Copy link
Author

I am taking a look at why the snapshot test resources were removed. That was not intentional

@pmairoldi
Copy link
Collaborator

I am looking at this today and I do not think we need to rename all the source files. We can just change the product name. I will take some of these changes but leave the code reorg to the side. It will make maintainability easier for us to not reorg everything.

@pmairoldi pmairoldi self-assigned this Mar 11, 2023
@pmairoldi pmairoldi added this to the 5.0.0 milestone Mar 11, 2023
@pmairoldi
Copy link
Collaborator

Closed by #5027

@pmairoldi pmairoldi closed this Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants