bump min version to 13 for ios project #5062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Charts.xcodeproj/project.pbxproj
Outdated
There was a problem hiding this comment.
Hey, not sure if this was intended, but there is no need to bump the frameworks minimum deployment target to 13
added 2 commits
May 30, 2023 10:38
FelixHerrmann
approved these changes
May 30, 2023
|
@pmairoldi or @danielgindi thoughts on getting this merged in to try and resolve the test issues on the release branch? |
|
Thank you! Sorry I've been pretty busy. |
This was referenced Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Link 🔗
Attempts to fix testing issues here #5028
Goals ⚽
Fix testing issues for release 5.0.0
Implementation Details 🚧
Just bumps the iOS demo project min version to 13 (and tvOS)
Testing Details 🔍
This should fix tests as reported here #5028 (comment)